style: style video player controls for md/lg screens#26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CHOSE BRAND COLOR - TEAL/TURQUOISE # 06D6C4
media-chromecomponents for better UI/UX. Took inspiration from YouTube's video player.MediaControlBarfor comments in next issue/PRNotes
Changing
gapin themedia-volume-rangeadded gap between itself and themedia-mute-buttonleading to no overflow when thevolumeControlsbar was collapsed. Not sure why but it works and could be an underlying design decision from the component itself.