feat(frontend): create initial VideoPlayer#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created initial
VideoPlayerwith controls usingmedia-chrome. Usingmedia-chromewill allow custom control bar on primitives. Will be customizing the<MediaTimeRange>in another issue/PR for comments.Changes
useIsHydratedhook so Next knows when the page has finished hydration so it can run client side operations, for the case of this PR, renderingMediaController.Notes
Hydration
Media Chrome's controls are custom elements that "upgrade" on the client. This means a mutation on the DOM which didn't exist in the server rendered HTML. Since the page is SSR, React/Next compares server HTML against first client render and makes sure the markup match.
<div>placeholder so theres identical markup on both server and client renderThis is why the
useIsHydatedhook was created which was built onuseSyncExternalStorewhich returns