Update devcontainer image to use custom repository#99
Conversation
Use my own image, since I think it will start faster, is less bloated, and has all the tools I need.
WalkthroughThe Dev Container configuration in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.devcontainer/devcontainer.json (1)
3-3: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPin the image to an immutable digest or version tag.
Using the mutable
latesttag means dev environment rebuilds may pull different images over time, causing non-reproducible builds and unexpected breakages. Pin to a specific digest (ghcr.io/kdeal/devenv-cs:latest@sha256:...) or a version tag if available.- "image": "ghcr.io/kdeal/devenv-cs:latest", + "image": "ghcr.io/kdeal/devenv-cs:latest@sha256:abc123...", // or a version tag like :v1.2.3🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.devcontainer/devcontainer.json at line 3, The devcontainer image reference uses a mutable tag, so update the image entry in devcontainer.json to point to an immutable pinned reference instead of the current latest tag. Use the existing image key and replace the value with a specific digest or a fixed version tag so rebuilds always pull the same environment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.devcontainer/devcontainer.json:
- Line 3: The devcontainer image reference uses a mutable tag, so update the
image entry in devcontainer.json to point to an immutable pinned reference
instead of the current latest tag. Use the existing image key and replace the
value with a specific digest or a fixed version tag so rebuilds always pull the
same environment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: af87de20-b219-417f-a7a2-a89354cd1d29
📒 Files selected for processing (1)
.devcontainer/devcontainer.json
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0ec349491
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "name": "Default", | ||
| "image": "mcr.microsoft.com/devcontainers/universal:noble", | ||
| "image": "ghcr.io/kdeal/devenv-cs:latest", |
There was a problem hiding this comment.
Use an image that still provides the python launcher
This image drops the python executable that the dotfiles installer relies on: the published ghcr.io/kdeal/devenv-cs source is based on ubuntu:noble and installs python3-pip/python3-virtualenv, but not python-is-python3, so a fresh container does not get /usr/bin/python. Since the image also does not preinstall fish, setup reaches setup:22-23 on first Codespace creation and runs python $HERE/scripts/cmd_install.py fish, which exits with command-not-found before the dotfiles finish installing. Either keep an image with python, add the alias/package to this image, or update the installer to call python3.
Useful? React with 👍 / 👎.
Use my own image, since I think it will start faster, is less bloated, and has all the tools I need.
Summary by CodeRabbit