Skip to content

Update devcontainer image to use custom repository#99

Merged
kdeal merged 1 commit into
mainfrom
update_devcontainer
Jun 28, 2026
Merged

Update devcontainer image to use custom repository#99
kdeal merged 1 commit into
mainfrom
update_devcontainer

Conversation

@kdeal

@kdeal kdeal commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Use my own image, since I think it will start faster, is less bloated, and has all the tools I need.

Summary by CodeRabbit

  • Chores
    • Updated the development container image to a newer base environment.

Use my own image, since I think it will start faster, is less bloated, and has all the tools I need.
@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The Dev Container configuration in .devcontainer/devcontainer.json has its base Docker image changed from mcr.microsoft.com/devcontainers/universal:noble to ghcr.io/kdeal/devenv-cs:latest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: switching the devcontainer image to a custom repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update_devcontainer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.devcontainer/devcontainer.json (1)

3-3: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Pin the image to an immutable digest or version tag.

Using the mutable latest tag means dev environment rebuilds may pull different images over time, causing non-reproducible builds and unexpected breakages. Pin to a specific digest (ghcr.io/kdeal/devenv-cs:latest@sha256:...) or a version tag if available.

-    "image": "ghcr.io/kdeal/devenv-cs:latest",
+    "image": "ghcr.io/kdeal/devenv-cs:latest@sha256:abc123...", // or a version tag like :v1.2.3
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.devcontainer/devcontainer.json at line 3, The devcontainer image reference
uses a mutable tag, so update the image entry in devcontainer.json to point to
an immutable pinned reference instead of the current latest tag. Use the
existing image key and replace the value with a specific digest or a fixed
version tag so rebuilds always pull the same environment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.devcontainer/devcontainer.json:
- Line 3: The devcontainer image reference uses a mutable tag, so update the
image entry in devcontainer.json to point to an immutable pinned reference
instead of the current latest tag. Use the existing image key and replace the
value with a specific digest or a fixed version tag so rebuilds always pull the
same environment.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af87de20-b219-417f-a7a2-a89354cd1d29

📥 Commits

Reviewing files that changed from the base of the PR and between 7024004 and b0ec349.

📒 Files selected for processing (1)
  • .devcontainer/devcontainer.json

@kdeal kdeal merged commit c384908 into main Jun 28, 2026
3 checks passed
@kdeal kdeal deleted the update_devcontainer branch June 28, 2026 04:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b0ec349491

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{
"name": "Default",
"image": "mcr.microsoft.com/devcontainers/universal:noble",
"image": "ghcr.io/kdeal/devenv-cs:latest",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use an image that still provides the python launcher

This image drops the python executable that the dotfiles installer relies on: the published ghcr.io/kdeal/devenv-cs source is based on ubuntu:noble and installs python3-pip/python3-virtualenv, but not python-is-python3, so a fresh container does not get /usr/bin/python. Since the image also does not preinstall fish, setup reaches setup:22-23 on first Codespace creation and runs python $HERE/scripts/cmd_install.py fish, which exits with command-not-found before the dotfiles finish installing. Either keep an image with python, add the alias/package to this image, or update the installer to call python3.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant