Move off deprecated master branch of nvim-treesitter#97
Conversation
This requires installing tree-sitter so I added support for installing that to cmd_install.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
WalkthroughThis PR adds tree-sitter binary installation support and enhances archive extraction capabilities. It introduces tree-sitter v0.26.6 binary configuration for Linux architectures in cmd_install.toml, upgrades the installation script to handle gzip files and preserve executable permissions, and refactors the Neovim treesitter plugin configuration with a new build system and autocommand-based setup. Additionally, it updates several Neovim plugin commit hashes via lazy-lock.json. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7e80c9323
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with tempfile.TemporaryDirectory(delete=False) as tmp_dir: | ||
| tmp_path = Path(tmp_dir) / archive_name |
There was a problem hiding this comment.
Clean up temporary download directories
download_with_sha256 now creates a per-download directory with TemporaryDirectory(delete=False), but the install paths only delete the downloaded file afterward, so the parent temp directories are never removed. In workflows that run cmd_install repeatedly (for example CI/bootstrap scripts that download many tools), this leaks /tmp entries over time and can eventually hit inode or disk limits on long-lived machines.
Useful? React with 👍 / 👎.
This requires installing tree-sitter so I added support for installing that to cmd_install.
Summary by CodeRabbit
New Features
Chores