Skip to content

Move off deprecated master branch of nvim-treesitter#97

Merged
kdeal merged 1 commit into
mainfrom
treesitter
Mar 11, 2026
Merged

Move off deprecated master branch of nvim-treesitter#97
kdeal merged 1 commit into
mainfrom
treesitter

Conversation

@kdeal

@kdeal kdeal commented Mar 11, 2026

Copy link
Copy Markdown
Owner

This requires installing tree-sitter so I added support for installing that to cmd_install.

Summary by CodeRabbit

  • New Features

    • Added tree-sitter binary installation support (version 0.26.6) for Linux x64 and ARM64 architectures.
    • Improved archive extraction with enhanced gzip support and executable permissions preservation.
  • Chores

    • Updated Neovim plugins including conform.nvim, fzf, mini.nvim, nvim-lint, nvim-lspconfig, nvim-treesitter, nvim-web-devicons, snacks.nvim, and undotree.
    • Refactored treesitter configuration for better parser installation and highlighting support.

This requires installing tree-sitter so I added support for installing
that to cmd_install.
@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a553e08-1f97-4eb3-84bf-151f2f75e5b0

📥 Commits

Reviewing files that changed from the base of the PR and between ff8ca09 and d7e80c9.

📒 Files selected for processing (5)
  • cmd_install.toml
  • scripts/cmd_install.py
  • tests/test_cmd_install.py
  • xdg_config/nvim/lazy-lock.json
  • xdg_config/nvim/lua/plugins/treesitter.lua

Walkthrough

This PR adds tree-sitter binary installation support and enhances archive extraction capabilities. It introduces tree-sitter v0.26.6 binary configuration for Linux architectures in cmd_install.toml, upgrades the installation script to handle gzip files and preserve executable permissions, and refactors the Neovim treesitter plugin configuration with a new build system and autocommand-based setup. Additionally, it updates several Neovim plugin commit hashes via lazy-lock.json.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

codex

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch treesitter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kdeal

kdeal commented Mar 11, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kdeal kdeal merged commit b576a9e into main Mar 11, 2026
3 checks passed
@kdeal kdeal deleted the treesitter branch March 11, 2026 15:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7e80c9323

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/cmd_install.py
Comment on lines +191 to +192
with tempfile.TemporaryDirectory(delete=False) as tmp_dir:
tmp_path = Path(tmp_dir) / archive_name

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clean up temporary download directories

download_with_sha256 now creates a per-download directory with TemporaryDirectory(delete=False), but the install paths only delete the downloaded file afterward, so the parent temp directories are never removed. In workflows that run cmd_install repeatedly (for example CI/bootstrap scripts that download many tools), this leaks /tmp entries over time and can eventually hit inode or disk limits on long-lived machines.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant