specify target kubeconfig url via spec#245
Merged
kcp-ci-bot merged 3 commits intoJun 23, 2026
Merged
Conversation
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
kcp-ci-bot
added
kind/feature
This is required so we are not creating a breaking change On-behalf-of: SAP <simon.bein@sap.com> Signed-off-by: Simon Bein <simontheleg@gmail.com>
kcp-ci-bot
added
the
size/L
SimonTheLeg
changed the title
Member
Author
|
/retest |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 15313d9abb10e874dab43f23616925355ca99db6 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new top-level field to Kubeconfig object
targetWorkspaceand marks the currentAuthorization.clusterrolebindings.clusteras deprecated. I specifically chose to use a new field as A) the field now has overarching effect, not just for RBAC anymore B) to keep this from becoming a breaking change. Setting the new field also affects the server url of the generated kubeconfig object by appending the path to it. This allows you to create a kubeconfig targeted towards a specific workspace.For now the behavior is designed as follows:
Some implementation notices:
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #94
Release Notes