Skip to content

fix(player): align visible video preview controls#45

Merged
kcng0 merged 1 commit into
mainfrom
fix/visible-video-player-parity
Jul 23, 2026
Merged

fix(player): align visible video preview controls#45
kcng0 merged 1 commit into
mainfrom
fix/visible-video-player-parity

Conversation

@kcng0

@kcng0 kcng0 commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • use the shared video gesture surface in Visible gallery previews
  • match Invisible playback controls, settings, fit modes, orientation, and Back behavior
  • support long-press 2x fast-forward with release/cancel restoration
  • keep the change Dart-only for a Shorebird patch

Verification

  • flutter analyze lib/presentation/visible/gallery_preview_screen.dart lib/presentation/player/video_player_surface.dart lib/presentation/player/video_player_controls.dart
  • flutter test test/widget/video_player_controls_test.dart test/widget/player_screen_back_test.dart test/widget/viewer_screen_back_test.dart

Copilot AI review requested due to automatic review settings July 23, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kcng0
kcng0 merged commit d61e08d into main Jul 23, 2026
1 check passed
@kcng0
kcng0 deleted the fix/visible-video-player-parity branch July 23, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants