Skip to content

Add type hints to worker module #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaypee90 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add type hints to worker module #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f43097
Add comprehensive type hints to worker initialization and queue handling
kaypee90 Dec 1, 2025
62e4f4e
Fix add_slave parameter name and socket handling
kaypee90 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions zebrok/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ class TaskQueueWorker:
Listens and receives tasks and uses a task runner to execute them
"""

def __init__(self, connection, runner) -> None:
def __init__(
self, connection: BaseSocketConnection, runner: BaseTaskRunner
) -> None:
self.slaves: List[Any] = []
self.connection = connection
self.socket = self.connection.socket
Expand Down Expand Up @@ -79,11 +81,11 @@ def stop(self) -> None:
self.current_slave = 0
self.connection.close()

def add_slave(self, worker) -> None:
def add_slave(self, slave_socket: Any) -> None:
"""
Adds a slave worker to a master worker
Adds a slave worker socket to a master worker
"""
self.slaves.append(worker)
self.slaves.append(slave_socket)


class WorkerInitializer:
Expand Down Expand Up @@ -159,7 +161,9 @@ def _initialize_workers(self) -> None:
master_worker,
)

def _create_master_worker(self, *settings: Any):
def _create_master_worker(
self, *settings: Any
) -> Tuple[BaseSocketConnection, TaskQueueWorker]:
"""
Creates the main worker
"""
Expand All @@ -172,8 +176,8 @@ def _initialize_slave_workers(
max_workers: int,
host: str,
port: int,
master_socket: Any,
master_worker: Any,
master_socket: BaseSocketConnection,
master_worker: TaskQueueWorker,
) -> None:
"""
Creates worker threads as slaves to be associated with the main worker
Expand Down
Loading