hash_id: Change to xorshift*.#455
Merged
katef merged 1 commit intoJan 3, 2024
Merged
Conversation
katef's testing with words.sh found some suspicious timing, profiling with callgrind showed there's still some kind of bad collision behavior doing PHI64(a) ^ PHI64(b) with exactly two IDs. It's probably still a bad idea to combine multiple Fibonacci hashes, even with xor-ing rather than adding. Changing to xorshift* (another fast, high quality hash function for 64-bit ints) immediately makes the issue go away, so do that.
Owner
|
Current word.sh hits less sticky-out special cases (although they're still visible in the same spots, due to the text blab generates for the same seed): Noting that the total time for this trie is about the same as we were prior to #452 (see the same benchmark commented on that PR). So relative to main prior to #452, changing the hash improves things for the situation Scott mentions, but doesn't make anything worse elsewhere. |
katef
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was supposed to go in #452 -- it's what kate's "Scott confirmed this is uniformly better" was referring to -- but that got merged just before I pushed.
katef's testing with words.sh found some suspicious timing, profiling with callgrind showed there's still some kind of bad collision behavior doing PHI64(a) ^ PHI64(b) with exactly two IDs. It's probably still a bad idea to combine multiple Fibonacci hashes, even with xor-ing rather than adding.
Changing to xorshift* (another fast, high quality hash function for 64-bit ints) immediately makes the issue go away, so do that.