New feature: enable setting lock dir permissions - #1
Open
Trek333 wants to merge 1 commit into
Open
Conversation
The directory that is created by the acquire function (i.e. os.mkdir command) uses the default setting of mode=0o777 (i.e. world writable) with no way to change it. It is a security best practice to not create world writable objects, and vulnerability scanners are known to check for world writable objects. A mode parameter with a default value of 0o777 for backwards compatibility was added to the class constructor, and the mode parameter was added to the os.mkdir command to allow the mode value to be customized.
|
This would be a great release item! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The directory that is created by the acquire function (i.e. os.mkdir command) uses the default setting of mode=0o777 (i.e. world writable) with no way to change it. It is a security best practice to not create world writable objects, and vulnerability scanners are known to check for world writable objects. A mode parameter with a default value of 0o777 for backwards compatibility was added to the class constructor, and the mode parameter was added to the os.mkdir command to allow the mode value to be customized.