This repository was archived by the owner on May 12, 2021. It is now read-only.
logger: Fix syslog identifier#36
Merged
Merged
Conversation
Author
|
Related: kata-containers/proxy#29. |
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 41.7% 44.38% +2.67%
==========================================
Files 5 4 -1
Lines 199 178 -21
==========================================
- Hits 83 79 -4
+ Misses 108 91 -17
Partials 8 8
Continue to review full report at Codecov.
|
Member
|
lgtm |
Ensure log entries specify the name of the shim, not its path. Fixes kata-containers#35. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
fix-syslog-identifier
branch
from
f06f639 to
42d7d7a
Compare
Author
|
Rebased. |
Author
|
Hi @kata-containers/shim - could someone look at this one word code fix please? :) |
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure log entries specify the name of the shim, not its path.
Fixes #35.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com