Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Fix NaN validation and empty chain panic - #2

Merged
kassoulet merged 1 commit into
mainfrom
sentinel/fix-validation-and-panic-13196794189993750093
May 4, 2026
Merged

πŸ›‘οΈ Sentinel: [MEDIUM] Fix NaN validation and empty chain panic#2
kassoulet merged 1 commit into
mainfrom
sentinel/fix-validation-and-panic-13196794189993750093

Conversation

@kassoulet

Copy link
Copy Markdown
Owner

🚨 Severity: MEDIUM

πŸ’‘ Vulnerability:

  1. The application failed to validate that plugin parameters loaded from YAML mapping formats were finite numbers, allowing NaN or Infinity to enter the audio processing pipeline.
  2. Loading an empty plugin list via a YAML configuration file caused an index-out-of-bounds panic during the processing initialization.

🎯 Impact:

  • Denial of Service (DoS): An empty or malformed configuration file can crash the application.
  • Unstable Audio Processing: NaN values in DSP (Digital Signal Processing) can lead to extreme audio artifacts (loud noise or complete silence), potentially causing hearing damage or hardware issues if output is amplified.

πŸ”§ Fix:

  • Added is_finite() validation in src/config.rs for parameters defined in YAML mappings.
  • Centralized the plugins.is_empty() check in src/main.rs so it applies to both CLI and YAML input sources.

βœ… Verification:

  • Verified that NaN in YAML is now correctly rejected with an error message.
  • Verified that an empty plugin list in YAML now results in a clean error instead of a panic.
  • Ran the full test suite (cargo test) to ensure no regressions.

PR created automatically by Jules for task 13196794189993750093 started by @kassoulet

- Add is_finite() check for plugin parameters in YAML mapping format.
- Centralize empty plugin chain check to prevent panics when loading empty YAML configs.
- Update Sentinel journal.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@kassoulet
kassoulet merged commit 4f9c4d0 into main May 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant