Render the README and vignette figures at a lighter resolution#105
Merged
Conversation
The README rendered at dpi = 200 with fig.retina = 2 (effectively 400 dpi) and the vignettes at dpi = 200, so the shipped figures dominated the package: 4.0 Mb of README PNGs plus 4.5 Mb of base64-embedded vignette plots, 8.7 Mb installed. Render the README and both vignettes at dpi = 150 (no retina). The plots stay crisp at their display size, and the installed size drops to 4.6 Mb, clearing the installed-size check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README rendered at dpi = 200 with fig.retina = 2 (effectively 400 dpi) and the vignettes at dpi = 200, so the generated figures dominated the package: 4.0 Mb of README PNGs in man/figures plus 4.5 Mb of base64-embedded vignette plots, 8.7 Mb installed. On CRAN that draws an installed-size NOTE.
Render the README and both vignettes at dpi = 150 (no retina). The plots stay crisp at their display size (out.width unchanged, so GitHub/pkgdown layout is identical), and the installed size drops from 8.7 Mb to 4.6 Mb, so R CMD check --as-cran now reports checking installed package size ... OK. No R code or plot content changes.
Verified: re-rendered figures viewed for quality; --as-cran 0 errors / 0 warnings / 1 NOTE (dev-version only), installed-size check OK; README.md unchanged (img tags depend on out.width, not dpi).