Add cell.grid to box glyphs inside light cell rectangles#100
Merged
Conversation
New argument cell.grid (default FALSE) draws a light rectangle around every cell behind the glyphs and drops the through-center gridlines, so sized glyphs (method = "circle" or scale.square = TRUE) sit inside boxed cells. The border color is set with the companion cell.grid.col (default "grey90"). Has no effect on a full-tile square heatmap, whose tiles already carry an outline.color border. Existing calls are byte-identical.
The gridline blanking was applied whenever cell.grid = TRUE, including for a full-tile square heatmap where no cell box is drawn to replace the gridlines. On a lower/upper triangle that stripped the visible gridlines in the blank half, contradicting the documented "no effect on a full-tile square heatmap". Blank the panel grid only when a cell box was actually drawn (tracked per layout, since a mixed layout always boxes the diagonal). Strengthen the no-op test to assert the theme, not only the built data, and add gridlines to WORDLIST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New argument
cell.grid(defaultFALSE) draws a light rectangle around every cell, behind the glyphs, and drops the through-center gridlines. Sized glyphs (method = "circle"orscale.square = TRUE) then sit inside boxed cells instead of floating on the center gridlines. The border color is set with the companioncell.grid.col(default"grey90").Has no effect on a full-tile square heatmap (
method = "square"withoutscale.square), whose tiles already carry anoutline.colorborder, so no second box is drawn and its gridlines are left intact. In a mixed layout every region is boxed except full-tile square regions.Non-regression
cell.grid/cell.grid.col.Tests
tests/testthat/test-cell-grid.R: layer order (background tile before the glyph), no tile and unchanged theme for full-tile squares,cell.grid.colhonored, gridlines blanked only when boxes are drawn, mixed-layout boxing, and the default (cell.grid = FALSE) producing identical output.cell grid circle).R CMD check --as-cran: 0 errors / 0 warnings / 1 NOTE (dev-version incoming-feasibility only).