Skip to content

chore: update android code to kotlin #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kartikbhalla12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update android code to kotlin #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath "com.android.tools.build:gradle:7.2.1"
classpath "com.android.tools.build:gradle:8.2.2"
// noinspection DifferentKotlinGradleVersion
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
Expand Down Expand Up @@ -58,11 +58,11 @@ android {
}
}

compileSdkVersion getExtOrIntegerDefault("compileSdkVersion")
compileSdkVersion 34

defaultConfig {
minSdkVersion getExtOrIntegerDefault("minSdkVersion")
targetSdkVersion getExtOrIntegerDefault("targetSdkVersion")
minSdkVersion 24
targetSdkVersion 34

}

Expand Down Expand Up @@ -90,11 +90,10 @@ repositories {
def kotlin_version = getExtOrDefault("kotlinVersion")

dependencies {
// For < 0.71, this will be from the local maven repo
// For > 0.71, this will be replaced by `com.facebook.react:react-android:$version` by react gradle plugin
//noinspection GradleDynamicVersion
//noinspection GradleDependency
implementation "com.facebook.react:react-android:+"
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
implementation "com.truecaller.android.sdk:truecaller-sdk:3.0.0"
// Update to latest OAuth SDK 3.1.0
implementation "com.truecaller.android.sdk:truecaller-sdk:3.1.0"
}

249 changes: 0 additions & 249 deletions android/src/main/java/com/kartikbhalla/truecaller/TruecallerAndroidModule.java
View file
Open in desktop

This file was deleted.

Loading
Loading