Skip to content

add refresh button to portfolio page #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danfro wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add refresh button to portfolio page #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a148342
add refresh button to portfolio page
Danfro Apr 23, 2026
ef7bd46
try to cover for rate limit error or better avoid it
Danfro Apr 25, 2026
4994524
drop complex python usage for refreshing, use existing function
Danfro Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions qml/PortfolioPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Page {
header: PageHeader {
title: "Portfolio"
ActionBar {
numberOfSlots: 2
numberOfSlots: 3
anchors.right: parent.right
actions: [
Action {
Expand All @@ -28,8 +28,12 @@ Page {
reloadPortfolios()
}
}
},
Action {
iconName: "view-refresh"
text: i18n.tr("Refresh")
onTriggered: reloadPortfolios()
}

]
}
}
Expand Down Expand Up @@ -79,6 +83,7 @@ Page {
// === Holdings Header ===
Text {
text: "Your Holdings" + " Worth ($" + totalValue.toFixed(2)+")"
color:AppTheme.getThemeColors(theme.name).textColorPrimary
font.bold: true
font.pixelSize: units.gu(2.2)
}
Expand Down
128 changes: 93 additions & 35 deletions src/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,44 +75,102 @@ def get_coins(limit=1000):
pages = (limit + per_page - 1) // per_page
results = []

# Rate-limiting / retry config
max_retries = 3
min_wait_on_429 = 60 # wait at least 60s when a 429 is received
calls_per_minute = 10 # target pacing inside the allowed limit of 5 - 15 calls per minute
min_interval = 60.0 / calls_per_minute

last_request_time = 0.0

for page in range(1, pages + 1):
# Construct the URL for the current page
url = f"{COINGECKO_BASE}/api/v3/coins/markets?vs_currency=usd&order=market_cap_desc&per_page={per_page}&page={page}&sparkline=false&price_change_percentage=1h,24h,7d,30d,90d"
#log.debug(f"[API] Fetching page {page}: {url}")

try:
# Use the requests session for the API call
response = session.get(url, timeout=30) # Increased timeout for data fetches
response.raise_for_status() # Raise HTTPError for bad responses (4xx or 5xx)

raw_data = response.content # Get raw bytes
#log.debug(f"Raw response for page {page}: {raw_data[:200]}...") # Log first 200 bytes
data = json.loads(raw_data.decode("utf-8"))

if not isinstance(data, list):
log.error(f"[Error] Unexpected data format for page {page}: {data}")
continue

for coin in data:
results.append({
"id": coin.get("id"),
"name": coin.get("name"),
"symbol": coin.get("symbol", "").upper(),
"price": coin.get("current_price"),
"change24h": coin.get("price_change_percentage_24h"),
"image": coin.get("image"),
"json": coin, # Keep the full JSON for debugging or future use
})
except requests.exceptions.HTTPError as e:
log.error(f"[HTTP Error] Page {page} failed with status {e.response.status_code}: {e.response.text}")
except requests.exceptions.ConnectionError as e:
log.error(f"[Connection Error] Page {page} failed: {e}. Check network and DNS resolution.")
except requests.exceptions.Timeout as e:
log.error(f"[Timeout Error] Page {page} timed out: {e}")
except json.JSONDecodeError as e:
log.error(f"[JSON Decode Error] Page {page} failed to parse JSON: {e}")
except Exception as e:
log.error(f"[Unexpected Error] Page {page} failed: {e}", exc_info=True) # exc_info to get traceback

retries = 0
while retries <= max_retries:
# pace requests to respect target rate
elapsed = time.time() - last_request_time
if elapsed < min_interval:
time.sleep(min_interval - elapsed)

try:
# Use the requests session for the API call
response = session.get(url, timeout=30) # Increased timeout for data fetches
last_request_time = time.time()

# Explicit handling for rate limiting (429)
if response.status_code == 429:
retry_after = response.headers.get("Retry-After")
if retry_after is not None:
try:
wait = max(min_wait_on_429, int(retry_after))
except ValueError:
wait = min_wait_on_429
else:
wait = min_wait_on_429

log.warning(f"[Rate Limit] Page {page} 429 received. Waiting {wait}s before retry #{retries+1}.")
time.sleep(wait)
retries += 1
continue

response.raise_for_status() # Raise HTTPError for bad responses (4xx or 5xx)

raw_data = response.content # Get raw bytes
data = json.loads(raw_data.decode("utf-8"))

if not isinstance(data, list):
log.error(f"[Error] Unexpected data format for page {page}: {data}")
break # skip this page and continue with next

for coin in data:
results.append({
"id": coin.get("id"),
"name": coin.get("name"),
"symbol": coin.get("symbol", "").upper(),
"price": coin.get("current_price"),
"change24h": coin.get("price_change_percentage_24h"),
"image": coin.get("image"),
"json": coin, # Keep the full JSON for debugging or future use
})
break # success -> exit retry loop

except requests.exceptions.HTTPError as e:
status = e.response.status_code if e.response is not None else None
if status == 429:
retry_after = e.response.headers.get("Retry-After") if e.response is not None else None
try:
wait = max(min_wait_on_429, int(retry_after)) if retry_after else min_wait_on_429
except ValueError:
wait = min_wait_on_429
log.warning(f"[HTTPError 429] Page {page}: waiting {wait}s before retry #{retries+1}.")
time.sleep(wait)
retries += 1
continue

log.error(f"[HTTP Error] Page {page} failed with status {status}: {e.response.text if e.response is not None else e}")
break

except requests.exceptions.ConnectionError as e:
log.error(f"[Connection Error] Page {page} failed: {e}. Check network and DNS resolution.")
break

except requests.exceptions.Timeout as e:
log.error(f"[Timeout Error] Page {page} timed out: {e}")
break

except json.JSONDecodeError as e:
log.error(f"[JSON Decode Error] Page {page} failed to parse JSON: {e}")
break

except Exception as e:
log.error(f"[Unexpected Error] Page {page} failed: {e}", exc_info=True) # exc_info to get traceback
break

else:
# executed if while loop exhausted without break (i.e., retries exceeded)
log.error(f"[Rate Limit] Page {page} exhausted retries ({max_retries}). Skipping page.")

# Return only up to the specified limit
return results[:limit]
Expand Down