make app translatable and add German translation - #7
Open
Danfro wants to merge 6 commits into
Open
Conversation
Danfro
commented
Apr 24, 2026
Danfro
left a comment
Danfro
left a comment
Author
There was a problem hiding this comment.
I reformatted the strings to use the .arg() parameter. This way translators can adjust the order of words and numbers e.g. for right-left writers or so. I also added an adjustment to use the set locale decimal separator e.g. comma for German.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works quite well. Only on the dashboard the bottom and header row can be badly readable with long translations. That is why I did increase the margin for the bottom and removed the spaces around the top strings.