Skip to content

fix(versioned_constants): fallback to default if failed to load the file #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prkpndy wants to merge 1 commit into
base: release/0.13.2
Choose a base branch
from
Open

fix(versioned_constants): fallback to default if failed to load the file #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions crates/rpc-replay/src/block_context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,18 @@ pub fn build_block_context(
let versioned_constants = if let Ok(path) = env::var("SNOS_BLOCKIFIER_VERSIONED_CONSTANTS_PATH") {
log::info!("Loading versioned constants from path: {}", path);
// Try to load versioned constants from the specified JSON file
VersionedConstants::try_from(Path::new(&path)).map_err(|e| {
log::error!("Failed to load versioned constants from file {}, {}", path, e);
FeltConversionError::CustomError(format!("Failed to load versioned constants from file: {}", e))
})?
match VersionedConstants::try_from(Path::new(&path)) {
Ok(data) => {
// Use the file if found
log::info!("Found the file at {}. Reading and using it!", path);
data
}
Err(e) => {
// Fallback to default if failed to load the file
log::warn!("Failed to load versioned constants from file {}, falling back to default, {}", path, e);
VersionedConstants::get(starknet_version).clone()
}
}
} else {
log::info!("Env for versioned constants not set. Using default values");
// Use the default versioned constants from the library
Expand Down
Loading