Skip to content

Fix: Helm post-delete hook #7678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Varshar21-07 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Helm post-delete hook #7678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
015e8f8
Fix: Helm post-delete hook
Jun 28, 2026
7df1175
Trigger CI re-run
Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion charts/karmada/templates/post-delete-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ spec:
set -ex
kubectl delete -f /opt/mount/ --ignore-not-found=true
kubectl delete -f /opt/crds/ --ignore-not-found=true -R
kubectl delete -f /opt/static-resources/ --ignore-not-found=true -R
for file in /opt/static-resources/*; do
if [ "$(basename "$file")" != "system-namespace.yaml" ]; then
kubectl delete -f "$file" --ignore-not-found=true -R || true
fi
done
Comment on lines +50 to +54

@gemini-code-assist gemini-code-assist Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using $(basename "$file") inside a loop spawns a subshell and executes an external binary (basename) for every file in the directory. Since the script is executed using bash, we can use bash's built-in parameter expansion ${file##*/} instead. This is more efficient, avoids spawning external processes, and is more robust as it doesn't rely on the availability of the basename command in the container image.

Additionally, we can add a check [[ -e "$file" ]] to ensure the file exists before attempting to delete it, preventing errors if the glob pattern does not match any files.

              for file in /opt/static-resources/*; do
                if [[ -e "$file" && "${file##*/}" != "system-namespace.yaml" ]]; then
                  kubectl delete -f "$file" --ignore-not-found=true -R || true
                fi
              done

kubectl delete cm/{{ $name }}-config -n {{ $namespace }} --ignore-not-found=true
kubectl delete deployment/{{ $name }}-controller-manager -n {{ $namespace }} --ignore-not-found=true
EOF
Expand Down