Skip to content

fix: prevent duplicate objects in FetchResourceTemplatesByLabelSelector #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barbierajput378-pixel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: prevent duplicate objects in FetchResourceTemplatesByLabelSelector #7671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17660d
fix: prevent duplicate objects in FetchResourceTemplatesByLabelSelector
barbierajput378-pixel Jun 27, 2026
a27ab2a
refactor: simplify FetchResourceTemplatesByLabelSelector by using ear…
barbierajput378-pixel Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/util/helper/binding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ func FetchResourceTemplatesByLabelSelector(
}
var objects []*unstructured.Unstructured
if err != nil || len(objectList) == 0 {
// fall back to call api server in case the cache has not been synchronized yet
// fall back to call api server
klog.Warningf("Failed to get resource template (%s/%s/%s) from cache, Error: %v. Fall back to call api server.",
resource.Kind, resource.Namespace, resource.Name, err)
unstructuredList, err := dynamicClient.Resource(gvr).Namespace(resource.Namespace).List(context.TODO(), metav1.ListOptions{LabelSelector: selector.String()})
Expand All @@ -370,8 +370,10 @@ func FetchResourceTemplatesByLabelSelector(
for i := range unstructuredList.Items {
objects = append(objects, &unstructuredList.Items[i])
}
return objects, nil
Comment thread
barbierajput378-pixel marked this conversation as resolved.
}

// Process cache objects
for i := range objectList {
unstructuredObj, err := ToUnstructured(objectList[i])
if err != nil {
Expand Down
Loading