Remove dead code surfaced by find_dead_code#8
Merged
Conversation
Drop six unreferenced functions: - db.py: upsert_symbol, upsert_reference, upsert_embedding (parser.py performs writes inline through batch_insert_embeddings and direct cursor calls; these helpers had no callers) - logging_config.py: get_parser_logger, get_git_logger - validation.py: validate_path_in_directory Also fix the transaction() docstring example to reference upsert_file, which is the actual function used in parser.py:594. Verified with the find_dead_code MCP tool (0 candidates after removal) and pytest on the touched modules (59 tests pass). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_dead_codeMCP tool:upsert_symbol,upsert_reference,upsert_embedding(db.py),get_parser_logger,get_git_logger(logging_config.py), andvalidate_path_in_directory(validation.py)transaction()docstring example indb.pyto referenceupsert_file(the actual function used inparser.py:594) instead of the now-removedupsert_symbolTest plan
find_dead_codereturns 0 candidates after the cleanuppytest tests/test_validation.py tests/test_logging.py tests/test_errors.py— 59/59 pass🤖 Generated with Claude Code