This repository was archived by the owner on Jun 22, 2020. It is now read-only.
optimize toEdge by using mutable.#279
Open
SteamShon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since toEdge is called lots of times, we think it is worth to optimize.
This is what @daewon reported
based on profile, we can notice that toMap on list and ++ on two list takes many cpu time on toEdge.
we can avoid toMap and ++ by using mutable map and give up functional style here. I think code looks ugly(not too bad), but we can remove unnecessary cpu usage. I would be minor tuning but toEdge is called many many times(called once on every fetched edges).