Skip to content

Threadleak check#1

Open
kaisun2000 wants to merge 131 commits into
masterfrom
threadleak_check
Open

Threadleak check#1
kaisun2000 wants to merge 131 commits into
masterfrom
threadleak_check

Conversation

@kaisun2000

@kaisun2000 kaisun2000 commented Sep 30, 2020

Copy link
Copy Markdown
Owner

Issues

  • My PR addresses the following Helix issues and references them in the PR description:

(apache#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)

Description

  • Here are some details about my PR, including screenshots of any UI changes:

(Write a concise description including what, why, how)

Tests

  • The following tests are written for this issue:

(List the names of added unit/integration tests)

  • The following is the result of the "mvn test" command on the appropriate module:

(Before CI test pass, please copy & paste the result of "mvn test")

Documentation (Optional)

  • In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

Commits

  • My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Code Quality

  • My diff has been formatted using helix-style.xml
    (helix-style-intellij.xml if IntelliJ IDE is used)

@maxim-lobanov maxim-lobanov mentioned this pull request Oct 2, 2020
Closed
@kaisun2000 kaisun2000 force-pushed the threadleak_check branch 6 times, most recently from c97b3df to 1af98ef Compare October 8, 2020 01:57
@kaisun2000 kaisun2000 force-pushed the threadleak_check branch 5 times, most recently from 3cd98c5 to 2bc27d5 Compare October 14, 2020 02:18
narendly and others added 15 commits November 17, 2020 11:47
@narendly
Fix bug in resetting ByteArrayZkClient (apache#1531)
c090ec0 
It was discovered that even though there was a routing data change, _byteArrayZkClient was not being created anew using the newly read routing data. This would cause issues with the zookeeper endpoints provided through Helix REST. This change cleans up some internal methods and ensures that the byte array zk client gets nullified every time there is routing data change.

More specifically, the code was closing byteArrayDataAccessor but not byteArrayZkClient. This meant that the same byteArrayZkClient would be used even though everything was reset and routing data was updated. Hence, the data accessor was not really being created from scratch. This change makes sure that the underlying byteArrayZkClient gets closed and nullified upon routing data change.
@kaisun2000
Stabilizing several tests by giving a starting up waiting periods (ap…
1d6d607 
…ache#1533)

Stabilizing several tests by giving a starting up waiting periods up-on constructing BestPossibleExternalViewVerifier.

Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
@kaisun2000
fix TestHelixAdminCli testDeactivateCluster flakiness (apache#1535)
1b01972 
Fix TestHelixAdminCli testDeactivateCluster flakiness. As this test does not wait till the cluster converge before tearing it down. The tearing down process can have exceptions depending on timing.

Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
@kaisun2000
fix two flaky test. TestHelixZkClient may fail if there is session (a…
c7447c6 
…pache#1536)

Fix two flaky tests. TestHelixZkClient may fail if there is session changes. TestClusterStatusMonitorLifecycle may fail if the asyn thread pool tearning down is slow (asyncly). Both happen rarely but do happen.

Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
@kaisun2000
TestRoutingDataCache can be flaky if entering the test the cluster (a…
ed25f56 
…pache#1538)

TestRoutingDataCache can be flaky if entering the test the cluster is not in a stable state. We fix it by wait till the cluster is stable.

Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
@bfreuden
Compilation and execution errors in tutorial doc page (apache#1527)
319e89d 
Fixed bug apache#1516: Tutorial doc page leads to compilation and execution errors.

Co-authored-by: Bruno Freudensprung <bruno.freudensprung@kairntech.com>
@kaisun2000
Fix several tests with resource leakage (apache#1534)
540c53b 
Fix several tests with resource leakage.

Co-authored-by: Kai Sun <ksun@ksun-mn1.linkedin.biz>
Implement thread leakage check for each test class apache#1226
182661a 
Recently unit test can not complete due to threads leaking
and ZK session leaking. We identified the leaks and fixed
them. In order for future test not to leak resources, we
need a way to enforce test class would release/clean up resource created during test.

A check is implemented in @afterclass in ZkTestBase.java.
minor cleanup
908c98c
refactor a bit based on feedback.
59b8301
compiles and fix a null pointer case.
23a817f
add logs to track detailed clean-up steps in test.
81b96c4
1/ make sure all test method in one test are called in one batch
8f3fc0f 
thus we can attribute the thread leakage accordingly

2/ fix thread leakage in apache#1247, apache#1246, apache#1245, apache#1244, apache#1241, apache#1240
make TestRoutingTableProviderPeriodicRefresh not leaking when test fa…
0fd06a5 
…iled.

TestRoutingTableProviderPeriodicRefresh is still flaky. Totally depends
on timing.
fix flaky TestRoutingDataCache due to test method order issue. apache…
339324f 
…#1254
Kai Sun added 26 commits November 17, 2020 18:29
add waitTillWfcUpdate for TaskDriver start() to avoid race condition …
83d8bcf 
…when

adding job configs.
revert sleep in enqueue jobs and stopping rebalancer
95c39c9
revert 2 more files with stopping pipeline.
81e4734
WorkflowConfig.disableJobPurge as temp fix
a83e309
disable purging job now for rest of the test case.
69ecfa2
touch
28c6c5f
try code change to trigger test run.
66ddaef
remove disableJobPurge(). instead set purgeInterval -1 in config.
7be65eb
revert using shutdownNow() in TestMultiZkHelixJavaApis and make
4a76784 
shutdownNow() not public.
revert all production code change
e61441c
some fixes based on Ali's feedback.
6f7d657
on par with master
a6f188a
address rest of Ali's comment
083f09c
add more log for apache#1419
bdb14f3
rebase the branched out code.
a4323b0
clean some files
17b41ac
one round of self review
df49e45
missed an critical sleep in TestDelayedAutoRebalance.testPartitionMov…
6e61295 
…ementAfterDelayTime

from merge. Added it back.
remove first part of afterclass log
8692032
2nd part removing afterclass log
1036b72
remove all the phantom read related task fix, as they are in a
410ee76 
separate pr now.
add todo for task force delete job.
e8ac8b0
first batch change based on review
c633070
one more log4j
529237c
make changes based on jj's feedback.
8a04819
merge in fix of test routing table provider perodic refersh.
f3cbb1e
@johentsch johentsch mentioned this pull request Jul 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaisun2000 @narendly @bfreuden