Allow Unicode characters including emojis in nicknames#18
Open
JamesTsetsekas wants to merge 1 commit into
Open
Allow Unicode characters including emojis in nicknames#18JamesTsetsekas wants to merge 1 commit into
JamesTsetsekas wants to merge 1 commit into
Conversation
|
@JamesTsetsekas Does it is supported by original API? |
Author
|
tbh im not sure, i just noticed on my android client i was able to put emojis in my name and wanted similar functionality in this project. |
current problem is new noise protocol not supported by android app |
|
@JamesTsetsekas can I add this changes it to #7? |
Author
Sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌍 Allow Unicode characters including emojis in nicknames
This update removes the restrictive alphanumeric-only validation for nicknames and replaces it with Unicode-friendly validation that allows emojis and international characters while still preventing potentially harmful control characters.
Changes:
Replaced isalnum() check with control character filtering
Users can now use emojis like 🟧Python, 🚀Alice, or international names like José, محمد
Still blocks control characters (\n, \r, \t, \0) for security
Maintains existing length limits and reserved name restrictions
Example usage:
This makes BitChat more inclusive and expressive while maintaining security standards! 🎉