Skip to content

kwarg for session #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wcummings wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kwarg for session #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hammock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class Hammock(object):

HTTP_METHODS = ['get', 'options', 'head', 'post', 'put', 'patch', 'delete']

def __init__(self, name=None, parent=None, append_slash=False, **kwargs):
def __init__(self, name=None, parent=None, append_slash=False, session=None, **kwargs):
"""Constructor

Arguments:
Expand All @@ -19,7 +19,7 @@ def __init__(self, name=None, parent=None, append_slash=False, **kwargs):
self._name = name
self._parent = parent
self._append_slash = append_slash
self._session = requests.session()
self._session = session if session is not None else requests.session()

@archer31 archer31 Sep 4, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be modified to

self._session = session or requests.Session()

for k, v in kwargs.items():
orig = getattr(self._session, k) # Let it throw exception
if isinstance(orig, dict):
Expand Down