Skip to content

fix: gate proto tests behind protobuf feature flag #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacy merged 1 commit into from
Feb 12, 2026
Merged

fix: gate proto tests behind protobuf feature flag #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ jobs:
- name: fmt
run: cargo fmt --all --check
- name: clippy
run: cargo clippy --workspace -- -D warnings
run: cargo clippy --workspace --features protobuf -- -D warnings
- name: check
run: cargo check --workspace
run: cargo check --workspace --features protobuf

test:
name: test
Expand All @@ -38,9 +38,9 @@ jobs:
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
- name: build
run: cargo build --workspace
run: cargo build --workspace --features protobuf
- name: test
run: cargo test --workspace
run: cargo test --workspace --features protobuf

build:
name: build
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ release:
cargo build --release

test:
cargo test --workspace
cargo test --workspace --features protobuf

fmt:
cargo fmt --all
Expand All @@ -22,7 +22,7 @@ fmt-check:
cargo fmt --all --check

clippy:
cargo clippy --workspace -- -D warnings
cargo clippy --workspace --features protobuf -- -D warnings

check: fmt-check clippy test

Expand Down
3 changes: 3 additions & 0 deletions tests/integration/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,6 @@ bytes = { workspace = true }
ember-protocol = { workspace = true }
prost-reflect = { workspace = true }
tempfile = "3"

[features]
protobuf = []
1 change: 1 addition & 0 deletions tests/integration/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ mod cli;
mod cluster;
mod data_types;
mod persistence;
#[cfg(feature = "protobuf")]
mod proto;
mod pubsub;