feat: integration test suite - #76
Merged
Merged
Conversation
adds a test harness that spawns a real ember-server, connects via TCP, sends RESP3 commands, and asserts responses. covers 45 tests across: - basic operations (SET/GET, DEL, INCR, EXPIRE, MGET, SCAN, etc.) - data types (lists, hashes, sets, sorted sets) - persistence (BGSAVE snapshot recovery, AOF replay) - authentication (requirepass, AUTH command) - pub/sub (SUBSCRIBE, PSUBSCRIBE, PUBLISH)
- add build step before test in ci so the ember-server binary is available for integration tests that spawn it as a subprocess - remove tests/ from .dockerignore so the workspace member resolves during docker builds
kacy
force-pushed
the
feat/integration-tests
branch
from
February 10, 2026 02:15
04be78f to
7043161
Compare
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
* feat: add integration test suite adds a test harness that spawns a real ember-server, connects via TCP, sends RESP3 commands, and asserts responses. covers 45 tests across: - basic operations (SET/GET, DEL, INCR, EXPIRE, MGET, SCAN, etc.) - data types (lists, hashes, sets, sorted sets) - persistence (BGSAVE snapshot recovery, AOF replay) - authentication (requirepass, AUTH command) - pub/sub (SUBSCRIBE, PSUBSCRIBE, PUBLISH) * style: cargo fmt integration tests * fix: ci and docker compatibility for integration tests - add build step before test in ci so the ember-server binary is available for integration tests that spawn it as a subprocess - remove tests/ from .dockerignore so the workspace member resolves during docker builds * style: cargo fmt workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
adds an integration test crate that spawns a real ember-server as a subprocess, connects via TCP, and exercises the full request/response cycle over RESP3. 45 tests across five modules:
the test harness (
TestServer/TestClient) handles port allocation, server lifecycle, and RESP3 serialization/parsing. each test gets an isolated server instance.what was tested
cargo test --test integration— 45/45 passcargo clippy --tests --workspace -- -D warnings— cleancargo test --workspace— 798 tests pass (no regressions)design considerations
ServerOptionssupports both ownedTempDir(auto-cleanup) and borrowedPathBuf(for persistence restart tests that need the same directory across server instances)TestClient::read_frame()enables pub/sub tests by reading pushed messages without sending commands