fix: replace unwrap() on map lookups in migration manager - #64
Merged
Conversation
replace .unwrap() with .ok_or(MigrationError::NoMigrationInProgress) in start_import() and start_migrate(). while logically safe (the key was just inserted), a distributed system should handle state inconsistencies gracefully rather than crashing.
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
replace .unwrap() with .ok_or(MigrationError::NoMigrationInProgress) in start_import() and start_migrate(). while logically safe (the key was just inserted), a distributed system should handle state inconsistencies gracefully rather than crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
replaces two
.unwrap()calls inMigrationManager::start_import()andstart_migrate()with proper error handling using.ok_or(MigrationError::NoMigrationInProgress { slot }).while logically safe (the key was just inserted on the line before), a distributed system should handle state inconsistencies gracefully rather than crashing. the appropriate error variant already existed.
what was tested
cargo build -p ember-cluster— compiles cleanlycargo test -p ember-cluster— all 56 tests passcargo clippy -p ember-cluster— no warnings