feat: add core string and key commands - #56
Merged
Conversation
increment/decrement integer values by arbitrary amounts. makes incr_by public in keyspace so INCRBY/DECRBY route through it directly. includes full AOF persistence and recovery support.
increment float values by arbitrary amounts. adds IncrFloatError type and incr_by_float method to keyspace. persists as SET records in AOF to avoid float rounding drift during replay.
APPEND concatenates a value onto an existing string key (or creates it). STRLEN returns the byte length of a string value. both handle wrong-type errors and APPEND includes AOF persistence.
implements KEYS with glob pattern matching and RENAME with atomic key move. includes full pipeline: protocol parsing, keyspace methods, shard dispatch, AOF persistence, recovery, and connection routing. also fixes clippy warnings in INCRBYFLOAT tests (3.14 -> 2.72 to avoid approx_constant lint).
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
* feat: add INCRBY and DECRBY commands increment/decrement integer values by arbitrary amounts. makes incr_by public in keyspace so INCRBY/DECRBY route through it directly. includes full AOF persistence and recovery support. * feat: add INCRBYFLOAT command increment float values by arbitrary amounts. adds IncrFloatError type and incr_by_float method to keyspace. persists as SET records in AOF to avoid float rounding drift during replay. * feat: add APPEND and STRLEN commands APPEND concatenates a value onto an existing string key (or creates it). STRLEN returns the byte length of a string value. both handle wrong-type errors and APPEND includes AOF persistence. * feat: add KEYS and RENAME commands implements KEYS with glob pattern matching and RENAME with atomic key move. includes full pipeline: protocol parsing, keyspace methods, shard dispatch, AOF persistence, recovery, and connection routing. also fixes clippy warnings in INCRBYFLOAT tests (3.14 -> 2.72 to avoid approx_constant lint). * docs: update README with new string and key commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
what was tested
cargo clippy --all-targetspasses (fixed pre-existing approx_constant lint)cargo test— 695 tests, all passingdesign considerations
incr_by(key, -delta)rather than duplicating logicformat_floathelper matches Redis behavior (strips trailing zeros, integers without decimals)