chore: code audit and cleanup - #53
Merged
Merged
Conversation
- create connection_common.rs with BUF_CAPACITY, MAX_BUF_SIZE, IDLE_TIMEOUT - remove duplicate constant definitions from connection.rs and concurrent_handler.rs - add performance documentation to concurrent_handler.rs
- sorted set: infinity scores, empty set operations, inverted indices - keyspace: zero/small TTL expiry, auto-deletion of empty collections - keyspace: duplicate set members, overflow/underflow for incr/decr - keyspace: empty keys, empty values, binary data adds 22 new tests (223 -> 245 total)
- 245 tests (was showing 579 which was stale) - ~20k lines of code
- add achieved metrics vs targets (1.86M SET, 2.48M GET, 0.4ms p99) - update benchmark commands to use scripts folder - memory overhead: 257 bytes/key in concurrent mode
- memchr 2.7.6 -> 2.8.0 - zerocopy 0.8.38 -> 0.8.39
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
* refactor: extract shared connection constants - create connection_common.rs with BUF_CAPACITY, MAX_BUF_SIZE, IDLE_TIMEOUT - remove duplicate constant definitions from connection.rs and concurrent_handler.rs - add performance documentation to concurrent_handler.rs * test: add edge case tests for critical functionality - sorted set: infinity scores, empty set operations, inverted indices - keyspace: zero/small TTL expiry, auto-deletion of empty collections - keyspace: duplicate set members, overflow/underflow for incr/decr - keyspace: empty keys, empty values, binary data adds 22 new tests (223 -> 245 total) * docs: update test count in README - 245 tests (was showing 579 which was stale) - ~20k lines of code * docs: update CLAUDE.md with benchmark results - add achieved metrics vs targets (1.86M SET, 2.48M GET, 0.4ms p99) - update benchmark commands to use scripts folder - memory overhead: 257 bytes/key in concurrent mode * chore: update dependencies - memchr 2.7.6 -> 2.8.0 - zerocopy 0.8.38 -> 0.8.39 * fix: correct test count (609) and LOC (~14k non-test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
comprehensive codebase audit and cleanup:
connection_common.rschanges
code quality
new tests
documentation
dependencies
tested