feat: add --shards flag and improve benchmark comparisons - #44
Merged
Conversation
- add --shards N flag to ember-server to control shard count (defaults to available CPU cores) - update benchmark script to test both single-shard and multi-shard - add dragonfly support for multi-threaded comparison - add scaling efficiency section to show multi-core benefits - add --quick flag for reduced test matrix - document all new options in bench/README.md
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
feat: add --shards flag and improve benchmark comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
--shards Nflag to ember-server for controlling worker thread count (defaults to available CPU cores)--quickflag for reduced test matrixtested
note: scaling appears limited because
redis-benchmarkis single-threaded. for real multi-core stress testing, would need to run multiple benchmark processes in parallel.design notes
--shards 0is rejected with an errorember server starting... shards=8--dbfilename ""to disable persistence (matches redis--save "")