chore: phase 4 audit fixes and documentation updates - #35
Merged
Conversation
fixes: - log warnings when gossip event channel sends fail (was silently ignored) - remove semantically incorrect SlotRange::is_empty() method - add clippy allow for len_without_is_empty with proper documentation documentation: - update README.md: phase 4 complete, 574 tests, ~18k LOC - rewrite ember-cluster README with full feature list and usage - add invariant documentation to SlotRange
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
chore: phase 4 audit fixes and documentation updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post-phase-4 code audit with fixes and documentation updates:
code fixes:
let _)SlotRange::is_empty()method (always returned false)#[allow(clippy::len_without_is_empty)]with proper invariant documentationdocumentation updates:
SlotRangeTested
cargo test --workspace- 574 tests passcargo clippy --workspace- no warningscargo fmt --all- formattedDesign considerations
what was intentionally deferred:
audit findings addressed: