docs: accuracy pass — concurrent mode removal + command parity - #321
Merged
Conversation
update 5 markdown files to reflect the current state of the codebase: - changelog: replace "concurrent pipeline dispatch" with "parallel pipeline dispatch" (less ambiguous); remove the 0.2.x line about concurrent keyspace mode with dashmap (feature was removed in 0.4.8, keeping it as history is misleading) - architecture: bump command count reference 135+ → 150+; update footer to not pin the doc to the clustering milestone - bench/readme: bump dragonfly comparison count 135 → 150 - docs/migration-from-redis.md: command count header 135 → 150; mark 20 commands as ✓ across strings, lists, sets, sorted sets, hashes, keys, and server tables (getset, getdel, getex, msetnx, lmove, lmpop, smove, sintercard, zrandmember, zunion, zinter, zdiff, zmpop, hrandfield, wait, expireat, pexpireat, expiretime, pexpiretime, config rewrite); replace the "bit operations not planned" paragraph with a single line covering only bitfield/bitfield_ro; remove the getset → set key value get substitution from migration steps - docs/compatibility.md: setnx ✗ → ✓ with legacy alias note; add setex and psetex rows (also legacy aliases, present in migration guide but missing here)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
31 markdown files were audited. this PR fixes the documentation drift that accumulated across PRs #312 and #315–320.
CHANGELOG.md — two residual concurrent-mode mentions removed or reworded. the 0.2.x line referencing dashmap/concurrent keyspace mode is gone (feature was removed in 0.4.8; keeping it as history was misleading). the 0.3.x performance bullet is reworded to "parallel pipeline dispatch" to avoid ambiguity with the deprecated term.
ARCHITECTURE.md — command count bumped 135+ → 150+; footer updated to not pin the doc to the clustering milestone.
bench/README.md — dragonfly comparison count updated 135 → 150.
docs/migration-from-redis.md — the most impacted file. command count header updated. 20 commands marked ✓ across strings (GETSET, GETDEL, GETEX, MSETNX), lists (LMOVE, LMPOP), sets (SMOVE, SINTERCARD), sorted sets (ZRANDMEMBER, ZUNION, ZINTER, ZDIFF, ZMPOP), hashes (HRANDFIELD), keys (WAIT, EXPIREAT, PEXPIREAT, EXPIRETIME, PEXPIRETIME), and server (CONFIG REWRITE). the "bit operations not planned" paragraph (which listed implemented commands as unimplemented) is replaced with a single line covering only BITFIELD/BITFIELD_RO. the GETSET substitution is removed from the migration steps section since GETSET is now valid.
docs/compatibility.md — SETNX corrected from ✗ to ✓ with a legacy alias note (was added in 0.4.7). SETEX and PSETEX rows added (same release, present in migration guide but missing here).
what was tested
grep -r "concurrent mode\|DashMap\|dashmap\|concurrent keyspace" --include="*.md"— only hit is the 0.4.8 note documenting the removal, which is correct.grep -r "135+" --include="*.md"— zero results.design considerations
crates/ember-core/src/concurrent.rs(dashmap-based, ~36 tests) still exists in the codebase — removing it is a separate code cleanup PR. this PR touches markdown only.