feat: surface 17 new commands across cli, grpc, and client libraries - #320
Merged
Conversation
adds command metadata for all commands from prs #315–319: - generic: expireat, expiretime, pexpireat, pexpiretime - string: getset, msetnx - bitmap (new group): bitcount, bitop, bitpos, getbit, setbit - list: lmpop; update lpop/rpop args to include optional count - hash: hrandfield - set: sintercard, smove - sorted_set: zmpop, zrandmember all entries are alphabetically ordered within their group.
… zmpop, hrandfield, zrandmember
… lmpop, zmpop, hrandfield, zrandmember
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
wires up all 17 commands added in prs #315–319 across every surface that didn't have them yet: the cli autocomplete/help system, the grpc api, and all four client libraries (rust, go, python, typescript).
commands covered
three atomic commits:
feat(cli)— adds all 17 commands to the autocomplete/help metadata incommands.rs, updates lpop/rpop args to include the optional[count], and introduces the newbitmapgroup. all 114 cli tests pass.feat(grpc)— adds 17 new proto messages (ExpiretimeRequest,BitcountRequest,LmpopRequest/LmpopResponse,ZmpopRequest/ZmpopResponse, etc.), 17 new unary rpcs in the service, pipeline oneof entries 112–128 inPipelineRequest, and response variants 35–36 inPipelineResponse. grpc.rs gets all 17 handler functions following the existing routing pattern.feat(clients)— adds typed methods to all four clients. the rust client uses the samecmd2/cmd3/bytes_vec/scored_membershelpers as the rest of the file;lmpopandzmpopdecode the compound[key, elements]response shape inline. go/python/typescript wrap the generated grpc stubs with idiomatic apis including nullableLmpopResult/ZmpopResulttypes for the multi-key pop responses.what was tested
cargo test -p emberkv-cli— 114 tests pass (includescommands_sorted_within_groupswhich enforces alphabetical ordering within each group)cargo test -p ember-client— all unit and doc tests passcargo build -p ember-server— clean build with all new proto-generated types and handlers