fix: add AOF persistence for hash and set commands - #28
Merged
Conversation
critical bug fix: HSET, HDEL, HINCRBY, SADD, and SREM mutations were not being logged to the append-only file, causing data loss on restart. changes: - add AofRecord variants for HSet, HDel, HIncrBy, SAdd, SRem - implement serialization and deserialization for new record types - update recovery to replay hash and set mutations - extend to_aof_record() in shard.rs to emit new records - add round-trip tests for all new AOF record types - improve memory.rs documentation with platform notes - clarify MSET fan-out logic in connection.rs
kacy
added a commit
that referenced
this pull request
Feb 11, 2026
fix: add AOF persistence for hash and set commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
critical bug fix discovered during code audit: HSET, HDEL, HINCRBY, SADD, and SREM mutations were not being logged to the append-only file, causing data loss on restart when using AOF persistence.
AofRecordvariants forHSet,HDel,HIncrBy,SAdd,SRemto_aof_record()in shard.rs to emit new records on successful mutationsalso includes minor improvements from the audit:
memory.rswith platform notesconnection.rstest plan
design notes
the AOF format uses sequential tag numbers (14-18) for the new record types, maintaining backward compatibility with existing AOF files. the serialization format follows the same pattern as existing commands (length-prefixed fields with CRC32 checksums).