refactor: ember-persistence docs and test cleanup - #121
Merged
Conversation
…ator - format.rs: expand capped_capacity doc explaining the 65,536 cap choice and why it limits pre-allocation without capping iteration - snapshot.rs: convert test functions from unwrap chains to Result + ? for cleaner failure output and more idiomatic test style - aof.rs: same treatment for all test functions
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
…ator (#121) - format.rs: expand capped_capacity doc explaining the 65,536 cap choice and why it limits pre-allocation without capping iteration - snapshot.rs: convert test functions from unwrap chains to Result + ? for cleaner failure output and more idiomatic test style - aof.rs: same treatment for all test functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
capped_capacityfunction rationale in format.rs — explainswhy 65,536 was chosen as the cap and how it limits pre-allocation without
capping iteration count
unwrap()chainsto
Resultreturn types with?operator for cleaner failure outputwhat was tested
cargo test -p ember-persistence— all 67 tests passcargo check -p ember-persistencedesign considerations
the
type Result = std::result::Result<(), Box<dyn std::error::Error>>aliasis defined per test module to keep it local and avoid polluting the crate
namespace. tests that deliberately assert on error variants (like
corrupt_crc_detected) still useunwrap_err()since those are the actualassertions being tested.