harden ember-cluster — saturating arithmetic in migration progress - #105
Merged
Conversation
prevents theoretical u64 overflow when computing keys_migrated * 100 for progress percentage. while the overflow requires >1.8e17 keys to trigger, saturating_mul is zero-cost and eliminates the edge case entirely.
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
prevents theoretical u64 overflow when computing keys_migrated * 100 for progress percentage. while the overflow requires >1.8e17 keys to trigger, saturating_mul is zero-cost and eliminates the edge case entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
uses
saturating_mulin the migration progress percentage calculation to prevent a theoretical u64 overflow whenkeys_migrated * 100exceeds u64::MAX.while triggering this requires >1.8e17 keys (far beyond any practical scenario),
saturating_mulis zero-cost and makes the arithmetic unconditionally correct.what was tested
cargo clippy -p ember-clusterclean