harden ember-protocol — vector dimension and HNSW parameter caps - #103
Merged
Conversation
- add MAX_VECTOR_DIMS (65,536) to prevent memory abuse from absurdly large vectors in VADD and VSIM commands - add MAX_HNSW_PARAM (1,024) to validate M and EF values before the u64→u32 cast, preventing silent truncation and pointless resource use - all 296 existing tests pass unchanged
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
- add MAX_VECTOR_DIMS (65,536) to prevent memory abuse from absurdly large vectors in VADD and VSIM commands - add MAX_HNSW_PARAM (1,024) to validate M and EF values before the u64→u32 cast, preventing silent truncation and pointless resource use - all 296 existing tests pass unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
adds bounds checking to vector command parsing to prevent DoS through unbounded resource allocation:
u64 → u32cast. values above this give no practical benefit for HNSW and waste memory. prevents silent truncation on values > u32::MAX.what was tested
cargo clippy -p ember-protocolcleandesign considerations