Skip to content

refactor: extract_strings and extract_bytes_vec helpers in ember-protocol #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacy merged 1 commit into from
Feb 12, 2026
Merged

refactor: extract_strings and extract_bytes_vec helpers in ember-protocol #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 21 additions & 44 deletions crates/ember-protocol/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,16 @@ fn extract_bytes(frame: &Frame) -> Result<Bytes, ProtocolError> {
}
}

/// Extracts all frames in a slice as UTF-8 strings.
fn extract_strings(frames: &[Frame]) -> Result<Vec<String>, ProtocolError> {
frames.iter().map(extract_string).collect()
}

/// Extracts all frames in a slice as raw byte buffers.
fn extract_bytes_vec(frames: &[Frame]) -> Result<Vec<Bytes>, ProtocolError> {
frames.iter().map(extract_bytes).collect()
}

/// Parses a string argument as a positive u64.
fn parse_u64(frame: &Frame, cmd: &str) -> Result<u64, ProtocolError> {
let s = extract_string(frame)?;
Expand Down Expand Up @@ -893,32 +903,23 @@ fn parse_del(args: &[Frame]) -> Result<Command, ProtocolError> {
if args.is_empty() {
return Err(ProtocolError::WrongArity("DEL".into()));
}
let keys = args
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let keys = extract_strings(args)?;
Ok(Command::Del { keys })
}

fn parse_exists(args: &[Frame]) -> Result<Command, ProtocolError> {
if args.is_empty() {
return Err(ProtocolError::WrongArity("EXISTS".into()));
}
let keys = args
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let keys = extract_strings(args)?;
Ok(Command::Exists { keys })
}

fn parse_mget(args: &[Frame]) -> Result<Command, ProtocolError> {
if args.is_empty() {
return Err(ProtocolError::WrongArity("MGET".into()));
}
let keys = args
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let keys = extract_strings(args)?;
Ok(Command::MGet { keys })
}

Expand Down Expand Up @@ -1042,10 +1043,7 @@ fn parse_unlink(args: &[Frame]) -> Result<Command, ProtocolError> {
if args.is_empty() {
return Err(ProtocolError::WrongArity("UNLINK".into()));
}
let keys = args
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let keys = extract_strings(args)?;
Ok(Command::Unlink { keys })
}

Expand Down Expand Up @@ -1107,10 +1105,7 @@ fn parse_lpush(args: &[Frame]) -> Result<Command, ProtocolError> {
return Err(ProtocolError::WrongArity("LPUSH".into()));
}
let key = extract_string(&args[0])?;
let values = args[1..]
.iter()
.map(extract_bytes)
.collect::<Result<Vec<_>, _>>()?;
let values = extract_bytes_vec(&args[1..])?;
Ok(Command::LPush { key, values })
}

Expand All @@ -1119,10 +1114,7 @@ fn parse_rpush(args: &[Frame]) -> Result<Command, ProtocolError> {
return Err(ProtocolError::WrongArity("RPUSH".into()));
}
let key = extract_string(&args[0])?;
let values = args[1..]
.iter()
.map(extract_bytes)
.collect::<Result<Vec<_>, _>>()?;
let values = extract_bytes_vec(&args[1..])?;
Ok(Command::RPush { key, values })
}

Expand Down Expand Up @@ -1266,10 +1258,7 @@ fn parse_zrem(args: &[Frame]) -> Result<Command, ProtocolError> {
return Err(ProtocolError::WrongArity("ZREM".into()));
}
let key = extract_string(&args[0])?;
let members = args[1..]
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let members = extract_strings(&args[1..])?;
Ok(Command::ZRem { key, members })
}

Expand Down Expand Up @@ -1363,10 +1352,7 @@ fn parse_hdel(args: &[Frame]) -> Result<Command, ProtocolError> {
return Err(ProtocolError::WrongArity("HDEL".into()));
}
let key = extract_string(&args[0])?;
let fields = args[1..]
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let fields = extract_strings(&args[1..])?;
Ok(Command::HDel { key, fields })
}

Expand Down Expand Up @@ -1418,10 +1404,7 @@ fn parse_hmget(args: &[Frame]) -> Result<Command, ProtocolError> {
return Err(ProtocolError::WrongArity("HMGET".into()));
}
let key = extract_string(&args[0])?;
let fields = args[1..]
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let fields = extract_strings(&args[1..])?;
Ok(Command::HMGet { key, fields })
}

Expand All @@ -1432,10 +1415,7 @@ fn parse_sadd(args: &[Frame]) -> Result<Command, ProtocolError> {
return Err(ProtocolError::WrongArity("SADD".into()));
}
let key = extract_string(&args[0])?;
let members = args[1..]
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let members = extract_strings(&args[1..])?;
Ok(Command::SAdd { key, members })
}

Expand All @@ -1444,10 +1424,7 @@ fn parse_srem(args: &[Frame]) -> Result<Command, ProtocolError> {
return Err(ProtocolError::WrongArity("SREM".into()));
}
let key = extract_string(&args[0])?;
let members = args[1..]
.iter()
.map(extract_string)
.collect::<Result<Vec<_>, _>>()?;
let members = extract_strings(&args[1..])?;
Ok(Command::SRem { key, members })
}

Expand Down