[Not for merge]Link python lib to fix mkl not found#1032
Open
pkufool wants to merge 1 commit into
Open
Conversation
pkufool
changed the title
Collaborator
Author
|
@csukuangfj Do you have any other ideas to fix this issue? I think we discussed this issue before, you are in your holiday at that time. @glynpu found this issue. |
Collaborator
|
What are the error logs? I think the core library of k2 does not need Python. It is PyTorch that needs MKL. I suggest that we update the documentation to mention how to fix it rather than adding PYTHON as a dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pytorch distribution on CentOS does not include MKL library, so there will be linking error when compiling k2.
This PR can fix the issue because Python library contains MKL library, not a good way though. We might need other method to fix it, as we don't want k2core to depend on Python library.