fix(web): default the app to English (Korean is opt-in)#801
Open
k08200 wants to merge 1 commit into
Open
Conversation
A Korean-locale browser auto-switched the whole app (including /login) to Korean via navigator.language, so the effective default was Korean. - detectLocale() no longer follows the browser locale: it defaults to English and only returns Korean when the stored profile explicitly selects "ko". - Default profile language is now "en" (was "auto"); Settings → Language offers English / 한국어 (dropped the browser Auto-detect option). Both languages still work — Korean is one explicit click away.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #799. After the login page was fully localized, a
Korean-locale browser auto-switched the entire app (including
/login) to Korean, becausedetectLocale()fell back tonavigator.languagewhenever the profile language was unset or"auto".The intended default is English, with Korean available by explicit choice.
i18n.tsxdetectLocale()no longer follows the browser locale.It defaults to English and returns Korean only when the stored profile
explicitly selects
"ko".settings/page.tsx— the default profile language is now"en"(was
"auto"), and the Language dropdown offers English / 한국어(removed the browser "Auto-detect" option that produced the surprise).
Both languages still work — Korean is one explicit click away in
Settings → Language. This matches the landing site, which already
defaults to English.
Type
packages/web)Checklist
한국어selection still renders the app in Koreanen; Auto-detect option removed from Settingsbiome checkclean,tsc --noEmitpasses forpackages/webTest plan
pnpm install+prisma generate;biome checkon both files — pass;cd packages/web && npx tsc --noEmit— pass.next devand screenshotted/loginin ako-KRbrowser context (navigator.language === "ko-KR"):localStorage klorn-profile = {language:"ko"}→ page renders fully Korean.