Resource create api#125
Open
jwalz wants to merge 11 commits into
Open
Conversation
identifier workflow changes
…ntation (CenterForOpenScience#9980) ResourceSerializer and GET functionality on ResourceDetail Co-authored-by: Jon Walz <jonwalz@Admins-MBP.lan>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the ResourceList endpoint with POST functionality
Changes
datato identify the Registration being POSTed tocreatefunctionality to ResourceSerializeridentifierNULLable on theOutcomeArtifactpidinformation, just the RegistrationQA Notes
The Registration being POSTed to requires an Identifier, otherwise we cannot create the
PRIMARYOutcomeArtifact. Right now, Registrations only get an Identifier when they are made public. That meansEMBARGOEDRegistrations cannot have Resources.I suggest we create an empty
Identifierfor each Registration once it is approved and wait to mint the actual DOI until it becomes public, but that can be a follow-on PR (note that this will not create wasted Identifiers, as, under existing workflows, every approved registration is guaranteed to become public).Documentation
Side Effects
Ticket