Skip to content

Consolidate synthetic scene helpers#69

Merged
jwalin-shah merged 1 commit into
mainfrom
codex/WP-113-duplicate-logic-consolidation
May 14, 2026
Merged

Consolidate synthetic scene helpers#69
jwalin-shah merged 1 commit into
mainfrom
codex/WP-113-duplicate-logic-consolidation

Conversation

@jwalin-shah

Copy link
Copy Markdown
Owner

Summary

  • Extract shared colored-object scene generation, pairwise spatial facts, TL derived-state construction, and object-fact retraction into tensor_logic.research.synthetic_scene.
  • Route exp79 and exp83 through the canonical helper while preserving their old function names for existing scripts/tests.
  • Add tests that prove both experiment call paths use the canonical implementation and validate the retraction rule behavior.

Validation

  • PASS: python3 -m pytest tests/test_synthetic_scene_helpers.py tests/test_exp79.py -q
  • PASS: git diff --check
  • FAIL: python3 -m pytest -q
    • Existing unrelated failures in tests/test_tensor_logic_core.py::TensorLogicCoreTest::test_query_rejects_wrong_arity_and_unknown_symbols and ::test_recursive_query_rejects_wrong_arity.
    • The implementation raises "relation 'edge' expects 2 args, got N" while those assertions expect "edge expects 2 symbols, got N".

Residual Risk

  • Full-suite failure is outside this duplicate-helper surface and remains unresolved in this PR.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@jwalin-shah
jwalin-shah merged commit 6a791e4 into main May 14, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants