Skip to content

Make local validation gate authoritative#63

Closed
jwalin-shah wants to merge 2 commits into
mainfrom
codex/WP-029-local-validation-gate
Closed

Make local validation gate authoritative#63
jwalin-shah wants to merge 2 commits into
mainfrom
codex/WP-029-local-validation-gate

Conversation

@jwalin-shah

Copy link
Copy Markdown
Owner

Summary

  • add tools/local_validation.py as the single pre-handoff gate for pytest plus git diff --check
  • point CI and worker validation docs at the same gate
  • extend packaging/CI contract tests to prove the gate runs executable checks and exits nonzero on pytest failure

Validation

  • python3 -m pytest tests/test_packaging_ci.py -q
  • python3 -m pytest -q
  • git diff --check
  • python3 tools/local_validation.py

Residual risk: CI still needs to run on GitHub's Python 3.11 environment; local validation passed on this worktree.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@jwalin-shah

Copy link
Copy Markdown
Owner Author

Portfolio monitor review found a blocking follow-up before merge: Codex review flagged P2 that tools/local_validation.py uses git diff --check in a way that misses committed PR whitespace errors in CI/clean checkouts. Please compare against the PR base/merge-base or include staged/committed changes before merge.

@jwalin-shah

Copy link
Copy Markdown
Owner Author

Automated repair pass updated this PR, but did not merge it.

Result:

  • Repair worker completed and pushed a branch update.
  • Fresh Codex review still found blocking issue(s):
  • [P2] Check staged edits before passing local validation — /Users/jwalinshah/projects/.workpack-runs/WP-029/tools/local_validation.py:69-69
  • [P2] Avoid no-op committed diff checks on main pushes — /Users/jwalinshah/projects/.workpack-runs/WP-029/tools/local_validation.py:37-43

Repair packet: RP-025 for original WP-029
Local review packet: /Users/jwalinshah/projects/reports/review-repair-runs/RP-025.review.md

@jwalin-shah jwalin-shah closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants