Remove multithreading concepts from metal.rs#529
Open
jgilchrist wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Ah, will get this rebased |
jgilchrist
force-pushed
the
no-thread-stuff-in-metal-runtime
branch
2 times, most recently
from
fabcb06 to
50b3f2f
Compare
jgilchrist
commented
Jun 15, 2026
| matrices as NSUInteger, | ||
| (row_bytes * 4) as NSUInteger, | ||
| (matrix_bytes * 4) as NSUInteger, | ||
| (row_numel * 4) as NSUInteger, |
jgilchrist
commented
Jun 15, 2026
| /// The only concrete type that does get constructed in this | ||
| /// that does not also implement Send + Sync is MTLBuffer | ||
| /// and we only use this in a safe way | ||
| struct SendMetal<T: ?Sized>(Retained<ProtocolObject<T>>); |
Contributor
Author
There was a problem hiding this comment.
SendMetal and BufferEntry both go away
The original change had a lot of things wrapped in Mutex, Send, Atomic, etc. but training is single-threaded so it's all unnecessary. This switches everything to RefCell instead. It also removes BufferEntry which was a completely unnecessary wrapper around a dyn MetalBuffer.
jgilchrist
force-pushed
the
no-thread-stuff-in-metal-runtime
branch
from
50b3f2f to
628fb03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original change by Blightwidow had a lot of things wrapped in Mutex, Send, Atomic, etc. but training is single-threaded so it's all unnecessary.
This switches everything to RefCell instead. It also removes BufferEntry which was a completely unnecessary wrapper around a dyn MetalBuffer.