Remove re-export-only shim modules - #699
Conversation
flowrs-config's auth.rs and server.rs existed solely to re-export types from flowrs-airflow, which lib.rs then re-exported again. Nothing imported through flowrs_config::auth:: or flowrs_config::server::, so the middle hop was invisible to callers; lib.rs now re-exports from flowrs_airflow directly. auth.rs also exported four types (AstronomerAuth, ComposerAuth, MwaaAuth, MwaaTokenType) that lib.rs never forwarded and nothing used. Likewise composer/auth.rs was a one-line private module re-exporting crate::auth::ComposerAuth; composer/mod.rs now does that directly. Updates CLAUDE.md, which documented the two deleted files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0127jzUgqqy8JVX5RydfQxh8
|
Warning Review limit reached
Next review available in: 46 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Three modules whose entire body was
pub use.flowrs-config:auth.rsandserver.rsBoth re-exported types from
flowrs-airflow, andlib.rsthen re-exported them again:Nothing in the workspace imports through
flowrs_config::auth::orflowrs_config::server::— every caller uses the crate-root path. The middle hop was invisible to consumers, solib.rsnow re-exports fromflowrs_airflowdirectly and both files are gone.auth.rsalso exported four types (AstronomerAuth,ComposerAuth,MwaaAuth,MwaaTokenType) thatlib.rsnever forwarded and nothing imported — reachable only via a path no one used.The header comment called this "backward compatibility", but these are workspace-internal crates with no external consumers.
flowrs-airflow:managed_services/composer/auth.rsA one-line private module:
composer/mod.rsnow re-exportscrate::auth::ComposerAuthdirectly.Kept
server.rsalso re-exporteddefault_timeout, whichlib.rsgenuinely uses in three places. Those now importflowrs_airflow::config::default_timeoutdirectly rather than losing the function.Also
Updates
CLAUDE.md, which documented the two deletedflowrs-configfiles.Verification
cargo test --workspace --lib --bins(94 passing),cargo clippy --workspace --all-targets --all-features -- -D warnings, andcargo fmt --all --checkall clean.🤖 Generated with Claude Code
https://claude.ai/code/session_0127jzUgqqy8JVX5RydfQxh8
Generated by Claude Code