Skip to content

Remove re-export-only shim modules - #699

Open
jvanbuel wants to merge 1 commit into
mainfrom
claude/remove-reexport-shims
Open

Remove re-export-only shim modules#699
jvanbuel wants to merge 1 commit into
mainfrom
claude/remove-reexport-shims

Conversation

@jvanbuel

Copy link
Copy Markdown
Owner

What

Three modules whose entire body was pub use.

flowrs-config: auth.rs and server.rs

Both re-exported types from flowrs-airflow, and lib.rs then re-exported them again:

flowrs_airflow::AirflowAuth → flowrs_config::auth::AirflowAuth → flowrs_config::AirflowAuth

Nothing in the workspace imports through flowrs_config::auth:: or flowrs_config::server:: — every caller uses the crate-root path. The middle hop was invisible to consumers, so lib.rs now re-exports from flowrs_airflow directly and both files are gone.

auth.rs also exported four types (AstronomerAuth, ComposerAuth, MwaaAuth, MwaaTokenType) that lib.rs never forwarded and nothing imported — reachable only via a path no one used.

The header comment called this "backward compatibility", but these are workspace-internal crates with no external consumers.

flowrs-airflow: managed_services/composer/auth.rs

A one-line private module:

pub use crate::auth::ComposerAuth;

composer/mod.rs now re-exports crate::auth::ComposerAuth directly.

Kept

server.rs also re-exported default_timeout, which lib.rs genuinely uses in three places. Those now import flowrs_airflow::config::default_timeout directly rather than losing the function.

Also

Updates CLAUDE.md, which documented the two deleted flowrs-config files.

Verification

cargo test --workspace --lib --bins (94 passing), cargo clippy --workspace --all-targets --all-features -- -D warnings, and cargo fmt --all --check all clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_0127jzUgqqy8JVX5RydfQxh8


Generated by Claude Code

flowrs-config's auth.rs and server.rs existed solely to re-export types
from flowrs-airflow, which lib.rs then re-exported again. Nothing imported
through flowrs_config::auth:: or flowrs_config::server::, so the middle
hop was invisible to callers; lib.rs now re-exports from flowrs_airflow
directly. auth.rs also exported four types (AstronomerAuth, ComposerAuth,
MwaaAuth, MwaaTokenType) that lib.rs never forwarded and nothing used.

Likewise composer/auth.rs was a one-line private module re-exporting
crate::auth::ComposerAuth; composer/mod.rs now does that directly.

Updates CLAUDE.md, which documented the two deleted files.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0127jzUgqqy8JVX5RydfQxh8
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@jvanbuel, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: a332fda4-a002-446f-b703-2f6685fe8f6d

📥 Commits

Reviewing files that changed from the base of the PR and between c16ad73 and 50ccebe.

⛔ Files ignored due to path filters (1)
  • CLAUDE.md is excluded by !CLAUDE.md
📒 Files selected for processing (6)
  • crates/flowrs-airflow/src/managed_services/composer/auth.rs
  • crates/flowrs-airflow/src/managed_services/composer/client.rs
  • crates/flowrs-airflow/src/managed_services/composer/mod.rs
  • crates/flowrs-config/src/auth.rs
  • crates/flowrs-config/src/lib.rs
  • crates/flowrs-config/src/server.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/remove-reexport-shims

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants