Skip to content

autofix: No aarch64-unknown-linux-gnu build anywhere#101

Open
justrach wants to merge 1 commit into
release/sdk-typescript-0.1.8from
autofix/pr-87-1779296047048
Open

autofix: No aarch64-unknown-linux-gnu build anywhere#101
justrach wants to merge 1 commit into
release/sdk-typescript-0.1.8from
autofix/pr-87-1779296047048

Conversation

@justrach
Copy link
Copy Markdown
Owner

Auto-generated by codegraff-autofix from PR #87 review.

Finding: No aarch64-unknown-linux-gnu build anywhere (P1)
File:line: .github/workflows/sdk-typescript-publish.yml:92

Reviewer comment:

The pre-flight comment block (lines 12-17) lists @codegraff/sdk-linux-arm64-gnu as a subpackage requiring Trusted Publisher configuration. However, the build matrix (line 92-107) only covers aarch64-apple-darwin, x86_64-apple-darwin, and x86_64-pc-windows-msvc, and the build-linux job (line 162) only builds x86_64-unknown-linux-gnu. There is no job or matrix entry for aarch64-unknown-linux-gnu. Running this workflow as-is will publish a release that either omits the linux-arm64 subpackage entirely (stranding arm64 Linux users) or publishes it without a native .node binary, depending on napi prepublish behavior. Add the target: either add aarch64-unknown-linux-gnu as a matrix entry (if it can cross-compile from ubuntu-latest) or add a separate build-linux-arm64 job equivalent to build-linux.

🤖 patch generated by Codegraff agent in a sandbox.

agent: applied fix on .github/workflows/sdk-typescript-publish.yml:92

Addresses P1 finding on `.github/workflows/sdk-typescript-publish.yml:92` from review #4330389512.
@github-actions
Copy link
Copy Markdown

Action required: PR inactive for 5 days.
Status update or closure in 10 days.

@github-actions github-actions Bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant