[CI mirror] fix(coding-agent): revive archived sessions on prompt - #1
Closed
junhoyeo wants to merge 1 commit into
Closed
[CI mirror] fix(coding-agent): revive archived sessions on prompt#1junhoyeo wants to merge 1 commit into
junhoyeo wants to merge 1 commit into
Conversation
…-ending A window attached to a session the daemon later archives (idle eviction, RLM subagent archived after its final answer, parent deleting a finished child) stayed open but every keystroke failed with 'Unknown active session' forever, even though the transcript is saved and resumable. DaemonAgentConnection.prompt/promptAndWait now catch the unknown-session error, resume the saved session file via the daemon's idempotent create command, re-attach, emit session_resynced, and retry the prompt once. The revived binding is never published early: attach now takes an explicit target (attachSessionBinding) and the connection keeps its previous binding until the attach succeeds, so no concurrently started prompt can target a session this client has not attached to, and there is no rollback that could stomp a newer binding installed by a concurrent transition. A revival superseded by a session switch, reconnect, or update recovery fails, leaves the newer binding untouched, and releases the revived session's attachment (plus complete_owned_session for owned lifecycles, also on disposal mid-revival). attach() rejects a superseded response instead of rebinding backwards. The unknown-session match is exact and bound to the id the prompt targeted, and a concurrent prompt joins only a sibling revival of that same session. Reviving a killed session on a later prompt is deliberate: the agents view reply flow already resumes killed sessions, and a revived transcript is strictly recoverable.
Owner
Author
|
Fork has no registered workflows; running the CI matrix locally instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI mirror for upstream PR PrimeIntellect-ai#1039 (fork PRs need workflow approval upstream; this runs the identical ci.yml here). Not for merging into the fork's main.