Add database field support to migrations#48
Open
nlenepveu wants to merge 1 commit into
Open
Conversation
Allow migrations to specify which database tables should be created in by adding an optional `database` field to migration YAML files. Changes: - Extract `database` field from migration files in migrate_up() and migrate_down() - Add `database` to format_args for SQL template substitution - Update database query methods to accept optional database parameter - Modify update_schema() to query correct databases and use qualified table names - Include database field in generated migration template (commented out) The database field is optional and defaults to the current database connection (CLICKHOUSE_DB) when not specified, maintaining backward compatibility. This enables creating tables in different databases within the same ClickHouse instance, addressing the limitation where all tables were created in the default database.
Author
|
Hi @vinayak-mehta, could you please take a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow migrations to specify which database tables should be created in by adding an optional
databasefield to migration YAML files.Changes:
databasefield from migration files in migrate_up() and migrate_down()databaseto format_args for SQL template substitutionThe database field is optional and defaults to the current database connection (CLICKHOUSE_DB) when not specified, maintaining backward compatibility.
This enables creating tables in different databases within the same ClickHouse instance, addressing the limitation where all tables were created in the default database.