fix(clickhouse_client): support all table engines in schema generation#47
Open
nlenepveu wants to merge 1 commit into
Open
fix(clickhouse_client): support all table engines in schema generation#47nlenepveu wants to merge 1 commit into
nlenepveu wants to merge 1 commit into
Conversation
Remove MergeTree-only filter from get_database_tables() to include
tables with other engine types (S3, File, etc.) in schema.sql output.
Previously, the query filtered tables to only include those with
'MergeTree' in the engine name using:
AND position('MergeTree' IN engine) > 0
This caused S3 tables and other non-MergeTree engines to be excluded
from schema.sql generation, even though they were valid tables that
should be tracked.
The fix removes this restrictive filter while still excluding
MaterializedView and Dictionary engines, which have their own
dedicated methods.
Fixes schema.sql generation for S3-backed tables and other engine types.
Author
|
Hi @vinayak-mehta, could you please take a look when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove MergeTree-only filter from
get_database_tables()to include tables with other engine types (S3, File, etc.) in schema.sql output.Previously, the query filtered tables to only include those with 'MergeTree' in the engine name using:
This caused S3 tables and other non-MergeTree engines to be excluded from schema.sql generation, even though they were valid tables that should be tracked.
The fix removes this restrictive filter while still excluding MaterializedView and Dictionary engines, which have their own dedicated methods.
Fixes schema.sql generation for S3-backed tables and other engine types.