ALSA: Avoid closing a device while the audio thread is still using it - #1707
Draft
emezeske wants to merge 1 commit into
Draft
ALSA: Avoid closing a device while the audio thread is still using it#1707emezeske wants to merge 1 commit into
emezeske wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing the audio device can crash inside libasound, on setups using a large buffer at a low sample rate. A 4096 frame buffer at 8kHz is a 512ms read, and that is all it takes.
ALSAThread::close() waits 400ms for the audio thread to exit and then, if the thread still has i/o in progress, calls closeNow() on the devices from the calling thread to unstick it. That frees the snd_pcm_t while the audio thread may still be inside snd_pcm_readi or snd_pcm_writei, and the blocked thread then crashes inside libasound. The 400ms is shorter than a single read or write on plenty of perfectly valid configurations, so merely changing devices on such a setup is enough to free the handle out from under a thread that is not stuck at all and is just part way through one normal read.
This waits for the base timeout plus one i/o period, capped so that closing a genuinely wedged device stays responsive. A typical buffer size and sample rate is unaffected and still waits 400ms.